Restructure replication task implementation & UT #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
force-pushed
the
streaming-0
branch
from
93f7919
to
fb0a6e1
Compare
yux0
reviewed
Feb 28, 2023
| } | ||
|
|
||
| func (e *ExecutableWorkflowTask) HandleErr(err error) error { | ||
| // TODO original logic does not seem to have resend logic? |
There was a problem hiding this comment.
no resend logic for this task
yux0
approved these changes
Mar 6, 2023
wxing1292
added a commit
that referenced
this pull request
Mar 31, 2023
* Restructure replication task implementation & UT for ease of management
wxing1292
added a commit
that referenced
this pull request
Apr 14, 2023
* Restructure replication task implementation & UT for ease of management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
See above
How did you test it?
UT
Potential risks
N/A
Is hotfix candidate?
N/A