Flush buffer event when failing workflow task #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Mar 14, 2023
Comment on lines
+551
to
556
| // Flush buffer event before failing the workflow | ||
| ms.FlushBufferedEvents() | ||
|
|
||
| attributes := &commandpb.FailWorkflowExecutionCommandAttributes{ | ||
| Failure: wtFailedCause.workflowFailure, | ||
| } |
There was a problem hiding this comment.
i believe there is a util which flush & fail the workflow, can we plz use that util?
There was a problem hiding this comment.
There is a util to fail workflow task and flush. This one is to flush before fail the whole workflow.
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
* Flush buffer event when failing workflow task
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
* Flush buffer event when failing workflow task
wxing1292
pushed a commit
that referenced
this pull request
Apr 14, 2023
* Flush buffer event when failing workflow task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Flush buffer event when failing workflow task
Why?
When workflow task failed due to payload/search attribute size too large, it should flush buffer events before fail the workflow.
How did you test it?
Potential risks
Is hotfix candidate?