Add counter to track custom order by usage in Elasticsearch #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Mar 20, 2023
| @@ -735,6 +735,7 @@ func (s *visibilityStore) setDefaultFieldSort(fieldSorts []*elastic.FieldSort) [ | |||
| return defaultSorter | |||
| } | |||
|
|
|||
| s.metricsHandler.Counter(metrics.ElasticsearchCustomOrderByClauseCount.GetMetricName()).Record(1) | |||
There was a problem hiding this comment.
Can we check if the order by is not the same as default order.
There was a problem hiding this comment.
In a way, it's always different. If the user specifies ORDER BY, we're always adding run_id as tie breaker (L744 below). The default sort keys for ES is only close time and start time.
There was a problem hiding this comment.
We get here only if custom sort order is specified. If it is not there is an early exit at L735.
rodrigozhou
force-pushed
the
custom-order-by-counter
branch
from
4a00c46
to
c21e9dc
Compare
alexshtin
approved these changes
Mar 21, 2023
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
Add counter to track custom order by usage
wxing1292
pushed a commit
that referenced
this pull request
Apr 14, 2023
Add counter to track custom order by usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add counter to track custom order by usage in Elasticsearch.
Why?
How did you test it?
Potential risks
No risks.
Is hotfix candidate?
No.