Fix SQL visibility page token deserializer #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Mar 21, 2023
rodrigozhou
force-pushed
the
fix-sql-vis-page-token
branch
from
fe2a038
to
9f66846
Compare
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
wxing1292
pushed a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Check the page token is empty or not, instead of only checking if it's nil.
Why?
Bug (#4053) reported showed that the page token can be an empty slice.
How did you test it?
Added new unit tests, and checked the reported issue no longer happens.
Potential risks
No risks.
Is hotfix candidate?
No.