Add base workflow info to workflow replication task #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
force-pushed
the
streaming-workflow-reset
branch
3 times, most recently
from
572f222
to
e0560ba
Compare
wxing1292
force-pushed
the
streaming-workflow-reset
branch
from
e0560ba
to
1de2161
Compare
yux0
approved these changes
Mar 28, 2023
| @@ -196,6 +197,7 @@ type ( | |||
| GetWorkflowType() *commonpb.WorkflowType | |||
| GetWorkflowStateStatus() (enumsspb.WorkflowExecutionState, enumspb.WorkflowExecutionStatus) | |||
| GetQueryRegistry() QueryRegistry | |||
| GetBaseWorkflow() *workflowspb.BaseExecutionInfo | |||
There was a problem hiding this comment.
nit: GetBaseWorkflowResetPoint?
wxing1292
force-pushed
the
streaming-workflow-reset
branch
from
5add304
to
9e984cf
Compare
wxing1292
added a commit
that referenced
this pull request
Mar 31, 2023
* Add base workflow info to workflow replication task
wxing1292
added a commit
that referenced
this pull request
Apr 14, 2023
* Add base workflow info to workflow replication task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Attempt to make workflow reset base workflow info more generic
How did you test it?
Updated tests
Potential risks
N/A
Is hotfix candidate?