Add util to map shard IDs #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
force-pushed
the
shard-id-mapping
branch
4 times, most recently
from
6611836
to
e13b0fb
Compare
meiliang86
reviewed
Apr 18, 2023
| @@ -386,6 +386,40 @@ func WorkflowIDToHistoryShard( | |||
| return int32(hash%uint32(numberOfShards)) + 1 // ShardID starts with 1 | |||
| } | |||
|
|
|||
| func MapShardID( | |||
There was a problem hiding this comment.
Can you merge with the existing method?
func generateShardIDs(localShardId int32, localShardCount int32, remoteShardCount int32) []int32 {
var pollingShards []int32
if remoteShardCount <= localShardCount {
if localShardId <= remoteShardCount {
pollingShards = append(pollingShards, localShardId)
}
return pollingShards
}
// remoteShardCount > localShardCount, replication poller will poll from multiple remote shard.
for i := localShardId; i <= remoteShardCount; i += localShardCount {
pollingShards = append(pollingShards, i)
}
return pollingShards
}
There was a problem hiding this comment.
the behavior is actually different, generateShardIDs will not create a replication channel in this case
e.g.
64K shards pulll 16K shards, caller being 16K+1
meiliang86
approved these changes
Apr 18, 2023
samanbarghi
pushed a commit
to samanbarghi/temporal
that referenced
this pull request
May 2, 2023
* Add util to map shard IDs & UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
More utils
How did you test it?
UT
Potential risks
N/A
Is hotfix candidate?
N/A