Add dynamic config flag to disable worker versioning #4222
Conversation
| @@ -115,6 +115,8 @@ const ( | |||
| DeadlockInterval = "system.deadlock.Interval" | |||
| // How many extra goroutines can be created per root. | |||
| DeadlockMaxWorkersPerRoot = "system.deadlock.MaxWorkersPerRoot" | |||
| // Enable / disable worker versioning. | |||
| EnableWorkerVersioning = "system.workerVersioning.enable" | |||
There was a problem hiding this comment.
this should be something like frontend.workerVersioningData since it's controlling the frontend rpcs that read/write versioning data. we'll have another dynamic config for the matching behavior
| @@ -117,4 +117,5 @@ var ( | |||
| errBatchOpsMaxWorkflowExecutionCount = serviceerror.NewInvalidArgument("Workflow executions count exceeded.") | |||
|
|
|||
| errUpdateWorkflowExecutionAPINotAllowed = serviceerror.NewPermissionDenied("UpdateWorkflowExecution operation is disabled on this namespace.", "") | |||
| errWorkerVersioningNotAllowed = serviceerror.NewPermissionDenied("Worker versioning operations is disabled on this namespace.", "") | |||
There was a problem hiding this comment.
| errWorkerVersioningNotAllowed = serviceerror.NewPermissionDenied("Worker versioning operations is disabled on this namespace.", "") | |
| errWorkerVersioningNotAllowed = serviceerror.NewPermissionDenied("Worker versioning operations are disabled on this namespace.", "") |
There was a problem hiding this comment.
Sorry, I already merged this as I thought we'd use a single system-wide flag to control this behavior.
I still believe a single flag is preferable from the operator perspective.
I can fix the grammer in a separate PR.
There was a problem hiding this comment.
We already had a situation where I was very glad that we had separate controls for batch api and batch workers, for example. I can imagine similar situations with this feature, e.g. if we need to do some schema migration we might want to block updates but allow workflows to continue running. I'd rather do the more flexible thing.
There was a problem hiding this comment.
Okay, I'll change in a follow up PR
The feature is not ready yet and once it is, we'll still need a safe way to roll it out, hence this feature flag.