Correct spelling: updat_id -> update_id #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindaugasrukas
approved these changes
May 8, 2023
This was missed in a previous commit.
yycptt
approved these changes
May 8, 2023
mindaugasrukas
approved these changes
May 8, 2023
wxing1292
added a commit
that referenced
this pull request
May 11, 2023
This reverts commit 8fa4d3f.
|
It is great you found this before release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Correct spelling of column name updat_id -> update_id
Why?
That's not how you spell it.
How did you test it?
Ran
make install-schema-mysqlanddesc update_info_mapsto verify column nameFYI this these two lines are the only to instances of the string "updat_id" in the server repo.
Potential risks
We haven't released the server with this bug so I think it's ok to modify the versioned sql in place. If not I can create v1.10.1
Is hotfix candidate?
No