Bugfix: ExecutableTaskTracker LowWatermark funcion #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
commented
May 15, 2023
Comment on lines
+141
to
+144
| nextElement := element.Next() | ||
| delete(t.taskIDs, task.TaskID()) | ||
| t.taskQueue.Remove(element) | ||
| element = nextElement |
There was a problem hiding this comment.
this is the real bugfix, i.e. need to keep track of the next element when deleting the current element
wxing1292
force-pushed
the
fix-bug
branch
2 times, most recently
from
5037731
to
76abbcf
Compare
* LowWatermark should keep track the next element during element deletion * Use [inclusive, exclusive) range representation
yux0
approved these changes
May 15, 2023
wxing1292
added a commit
that referenced
this pull request
Jun 14, 2023
* LowWatermark should keep track the next element during element deletion * Use [inclusive, exclusive) range representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Bugfix & better maintenance
How did you test it?
UT
Potential risks
N/A
Is hotfix candidate?
N/A