Implement use_latest_build_id for activities, child workflows, continue-as-new #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
May 16, 2023
| @@ -2149,6 +2162,9 @@ func (ms *MutableStateImpl) ReplicateActivityTaskScheduledEvent( | |||
| scheduledEventID := event.GetEventId() | |||
| scheduleToCloseTimeout := attributes.GetScheduleToCloseTimeout() | |||
|
|
|||
| // always use latest build id if activity is on a different task queue than the workflow | |||
| useLatestBuildId := attributes.UseLatestBuildId || attributes.TaskQueue.GetName() != ms.executionInfo.TaskQueue | |||
There was a problem hiding this comment.
Caller concern, a binary may include multiple workers polling on different task queues.
There was a problem hiding this comment.
can you elaborate? I'm not sure how what you said relates to the code
There was a problem hiding this comment.
Respect the SDK's decision and don't override it server side.
There was a problem hiding this comment.
// always use latest build id if activity is on a different task queue than the workflow
Should be:
Use the latest build ID if indicated by the SDK.
There was a problem hiding this comment.
I got rid of all the task queue checks. I still have some concern about making the default behavior the least surprising thing, but it's up to the sdk now
dnr
added a commit
that referenced
this pull request
May 26, 2023
…ue-as-new (#4347) Note: This commit came from a feature branch and is not expected to build.
dnr
added a commit
to dnr/temporal
that referenced
this pull request
May 26, 2023
…ue-as-new (temporalio#4347) Note: This commit came from a feature branch and is not expected to build.
dnr
added a commit
that referenced
this pull request
May 26, 2023
…ue-as-new (#4347) Note: This commit came from a feature branch and is not expected to build.
dnr
added a commit
that referenced
this pull request
May 26, 2023
…ue-as-new (#4347) Note: This commit came from a feature branch and is not expected to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Thread
use_latest_build_idand build stamps where needed, respectuse_latest_build_id.Why?
Implement more feature
How did you test it?
Not yet
Potential risks
Is hotfix candidate?