Redirect spooled tasks using versioning directive #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
commented
May 18, 2023
| @@ -131,7 +131,7 @@ dispatchLoop: | |||
| // Don't try to set read level here because it may have been advanced already. | |||
| break | |||
| } | |||
| err := tr.tlMgr.DispatchTask(ctx, task) | |||
| err := tr.tlMgr.engine.DispatchSpooledTask(ctx, task, tr.tlMgr.taskQueueID) | |||
There was a problem hiding this comment.
this is kind of gross, sorry. I need to refactor some stuff here later and hopefully this will change then, but in the meantime it should at least work
bergundy
approved these changes
May 19, 2023
dnr
added a commit
that referenced
this pull request
May 26, 2023
Note: This commit came from a feature branch and is not expected to build.
dnr
added a commit
to dnr/temporal
that referenced
this pull request
May 26, 2023
Note: This commit came from a feature branch and is not expected to build.
dnr
added a commit
that referenced
this pull request
May 26, 2023
Note: This commit came from a feature branch and is not expected to build.
dnr
added a commit
that referenced
this pull request
May 26, 2023
Note: This commit came from a feature branch and is not expected to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When tasks come out of the db, pass them through versioning redirection again because versioning data may have changed (default may be different for first wft, or "active" set id may be different). Also, be able to interrupt the head blocking task and re-resolve if versioning data changes.
Why?
to make things work
How did you test it?
not yet