Bugfix: do not leak gRPC stream #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
commented
May 19, 2023
Comment on lines
-153
to
+149
| streamCreationTime, stream := r.getStream() | ||
| if err := r.ackMessage(stream); err != nil { | ||
| r.recreateStream(streamCreationTime) | ||
| if err := r.ackMessage(r.stream); err != nil { | ||
| r.logger.Error("StreamReceiver exit send loop", tag.Error(err)) | ||
| return |
There was a problem hiding this comment.
the solution is to not recreate the gRPC stream, rely on the stream monitor to recreate the entire thing
meiliang86
approved these changes
May 19, 2023
wxing1292
added a commit
that referenced
this pull request
Jun 14, 2023
* Do not recreate gRPC stream if error occurs, instead, rely on periodical health check to re-create stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Do not recreate gRPC stream since this will lead to resource leak
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A