Refactor UpdateWorkflowExecution functional tests #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/refactor-update-tests
branch
from
9712ab7
to
fe9c63f
Compare
mmcshane
approved these changes
May 24, 2023
tests/testvars/test_vars.go
Outdated
| func New(testName string) TestVars { | ||
| return TestVars{ | ||
| testName: testName, | ||
| kv: &sync.Map{}, |
There was a problem hiding this comment.
I probably would have held the sync.Map by value here and returned *TestVars
alexshtin
force-pushed
the
feature/refactor-update-tests
branch
from
002da65
to
95023ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor
UpdateWorkflowExecutionfunctional tests.Why?
To reduce code duplication, and make intend clear.
How did you test it?
Run test.
Potential risks
No risks.
Is hotfix candidate?
No.