Add the event batch ID to update CompletionInfo #4441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the event ID and the event batch ID are required when the read-through event cache does not find the event cached and must perform a lookup through the persistence layer.
alexshtin
approved these changes
Jun 6, 2023
|
Please rebase #4438 after merge. It should pass with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add the event batch ID to update CompletionInfo
Why?
Both the event ID and the event batch ID are required when the read-through event cache does not find the event cached and must perform a lookup through the persistence layer.
How did you test it?
Features test with cache disabled
Potential risks
Is hotfix candidate?