Enforce uniqueness of replication stream #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
force-pushed
the
better-stream
branch
3 times, most recently
from
f257661
to
3d0eec3
Compare
wxing1292
commented
Jun 7, 2023
| @@ -5,7 +5,7 @@ linters: | |||
| - goerr113 | |||
| - errcheck | |||
| - goimports | |||
| - paralleltest | |||
| # - paralleltest # missing the call to method parallel, but testify does not seem to work well with parallel test: https://github.com/stretchr/testify/issues/187 | |||
There was a problem hiding this comment.
@MichaelSnowden i am disabling the paralleltest linter since this will not work with testify, see above comments
* Unify stream implementations
yux0
reviewed
Jun 8, 2023
| h.streamReceiverMonitor.RegisterInboundStream(streamSender) | ||
| streamSender.Start() | ||
| defer streamSender.Stop() | ||
| streamSender.Wait() |
There was a problem hiding this comment.
Will it blocked and timed out?
There was a problem hiding this comment.
the caller will use a background context
when the context is cancelled, the stream sender will be marked as "stopped" and this wait invocation will unblock
|
|
||
| Stream BiDirectionStream[*adminservice.StreamWorkflowReplicationMessagesRequest, *adminservice.StreamWorkflowReplicationMessagesResponse] | ||
| StreamReceiver struct { | ||
| StreamReceiverImpl struct { |
yux0
approved these changes
Jun 8, 2023
mindaugasrukas
pushed a commit
that referenced
this pull request
Jun 8, 2023
* Enforce uniqueness of replication stream within stream monitor for both sender side & receiver side * Consolidate replication stream implementations; move logic to replication package
wxing1292
added a commit
that referenced
this pull request
Jun 14, 2023
* Enforce uniqueness of replication stream within stream monitor for both sender side & receiver side * Consolidate replication stream implementations; move logic to replication package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Better stream lifecycle control
How did you test it?
UT
Potential risks
N/A
Is hotfix candidate?
N/A