Remove unused metrics.ServiceIdx #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
snowden/dead-code
branch
from
b78a5b4
to
0714e8f
Compare
Oops, done |
dnr
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This change removes the
metrics.ServiceIdxtype and related functions. It also substitutes usages of it forprimitives.ServiceName, which were substituted eventually anyway.Why?
This type is only used to immediately translate to a
primitives.ServiceName. It isn't stored on the wire anywhere. It's just confusing to keep around.How did you test it?
The only parameter or variable with this type is the
serviceMetricsIndexparameter inNewTest, and all it does is immediately translate that value to aprimitives.ServiceNametype, so the only behavioral change is to short-circuit that logic.In addition, this was only used in test code any way.
Potential risks
Is hotfix candidate?