Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap setting futures in taskQueueManager #4494

Merged
merged 1 commit into from Jun 20, 2023
Merged

Wrap setting futures in taskQueueManager #4494

merged 1 commit into from Jun 20, 2023

Conversation

dnr
Copy link
Member

@dnr dnr commented Jun 14, 2023 •
edited

What changed?

  • Wrap setting initialized futures

Why?

  • Consolidate unload logic

How did you test it?
existing tests

Potential risks

Is hotfix candidate?

@dnr dnr requested a review from bergundy June 14, 2023 16:35
@dnr dnr requested a review from a team as a code owner June 14, 2023 16:35
bergundy
bergundy approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this exact code and never pushed it, I think this is cleaner than what we had before.

@bergundy bergundy merged commit 7f064ea into temporalio:master Jun 20, 2023
10 checks passed
@dnr dnr deleted the ver28 branch June 26, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnr @bergundy