Add per build id timestamp for when it was last made set default #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Jun 21, 2023
| QueueDefaultUpdateTimestamp: &clock, | ||
| }, | ||
| { | ||
| SetIds: []string{hashBuildId("2")}, | ||
| BuildIds: []*persistencespb.BuildId{{Id: "2", State: persistencespb.STATE_ACTIVE, StateUpdateTimestamp: &nextClock}}, | ||
| DefaultUpdateTimestamp: &nextClock, | ||
| BuildIds: []*persistencespb.BuildId{{Id: "2", State: persistencespb.STATE_ACTIVE, StateUpdateTimestamp: &nextClock, SetDefaultUpdateTimestamp: &nextClock}}, |
There was a problem hiding this comment.
Re-using mkBuildId would shorten things considerably
There was a problem hiding this comment.
Same for the rest of the other tests
| @@ -863,12 +838,11 @@ func TestMergeSets(t *testing.T) { | |||
| bothSetIds := mergeSetIDs([]string{hashBuildId("1")}, []string{hashBuildId("2")}) | |||
| assert.Equal(t, bothSetIds, updatedData.GetVersionSets()[1].GetSetIds()) | |||
| assert.Equal(t, initialData.GetVersionSets()[2].QueueDefaultUpdateTimestamp, updatedData.GetVersionSets()[1].QueueDefaultUpdateTimestamp) | |||
| assert.Equal(t, nextClock, *updatedData.GetVersionSets()[1].DefaultUpdateTimestamp) | |||
| assert.Equal(t, nextClock, *updatedData.VersionSets[1].BuildIds[len(updatedData.VersionSets[1].BuildIds)-1].SetDefaultUpdateTimestamp) | |||
There was a problem hiding this comment.
This access is a mouthful. Maybe make a little helper for these 3 spots
| @@ -39,6 +39,10 @@ message BuildId { | |||
| // (-- api-linter: core::0142::time-field-type=disabled | |||
| // aip.dev/not-precedent: Using HLC instead of wall clock. --) | |||
| temporal.server.api.clock.v1.HybridLogicalClock state_update_timestamp = 3; | |||
| // HLC timestamp representing when this build id was last made default in its version set. | |||
There was a problem hiding this comment.
Suggested change
| // HLC timestamp representing when this build id was last made default in its version set. | |
| // HLC timestamp representing when this build id was last made default in its version set, if ever. |
There was a problem hiding this comment.
We currently don't expose an API to add a build id without making it set default in a set
| // HLC timestamp representing when this build id was last made default in its version set. | ||
| // (-- api-linter: core::0142::time-field-type=disabled | ||
| // aip.dev/not-precedent: Using HLC instead of wall clock. --) | ||
| temporal.server.api.clock.v1.HybridLogicalClock set_default_update_timestamp = 4; |
There was a problem hiding this comment.
I think became_default_timestamp might be an easier to understand name
yiminc
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work done in #4524.
We now store a timestamp per build id denoting when it was last made default in its set.
This information will later be used by the scavenger to ensure that we don't delete build ids that have recently been set default giving enough time for outstanding tasks to be completed and visibility index to be updated.