Clean up cluster metadata initialization logic #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Jul 10, 2023
yycptt
approved these changes
Jul 10, 2023
wxing1292
pushed a commit
that referenced
this pull request
Jul 24, 2023
Clean up cluster metadata initialization logic
wxing1292
pushed a commit
that referenced
this pull request
Jul 24, 2023
Clean up cluster metadata initialization logic
nichtverstehen
pushed a commit
to nscloud-demo/temporal
that referenced
this pull request
Nov 23, 2023
…5143) <!-- Describe what has changed in this PR --> **What changed?** Fix setting up pre-allocated search attributes when a secondary SQL visibility is added. <!-- Tell your future self why have you made these changes --> **Why?** PR temporalio#4531 removed code that did this. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Started single SQL visibility, and then added secondary SQL visibility. Checked cluster metadata, it looks right. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
yux0
pushed a commit
to yux0/temporal
that referenced
this pull request
Nov 28, 2023
…5143) <!-- Describe what has changed in this PR --> **What changed?** Fix setting up pre-allocated search attributes when a secondary SQL visibility is added. <!-- Tell your future self why have you made these changes --> **Why?** PR temporalio#4531 removed code that did this. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Started single SQL visibility, and then added secondary SQL visibility. Checked cluster metadata, it looks right. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Clean up cluster metadata initialization logic
Why?
Make the logic to be more readable.
How did you test it?
Added unit tests
Potential risks
Is hotfix candidate?