Make all Go source file names snake case #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
I planned this change long time ago. Thanks @MichaelSnowden for doing it.
There was a problem hiding this comment.
This should be test_history_v2_persistence.go.
There was a problem hiding this comment.
Or I would better remove this test_ prefix because all these files are in persistence-tests directory.
There was a problem hiding this comment.
Makes sense. Removed this prefix from all the files in that dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I renamed all of our Go source code files so that they're snake case instead of camel case.
Why?
This was an annoying inconsistency we carried over from much older code in the repo.
How did you test it?
The renaming process was part of an automated script (https://gist.github.com/MichaelSnowden/47576fffe27aa1cae6b26eaccec7ab55), so it should be consistent. Also, I don't see us doing anything in our codebase that involves parsing our own source files by path:
PS: here's a link to the GPT convo I had to generate this renaming script: https://chat.openai.com/share/7f2d011a-a8da-4fa4-9c6d-e09102fdd49f
Potential risks
Mainly merge conflicts, but I used
git mvso that these are renames instead of deletes/adds, so that shouldn't be a big issue.Is hotfix candidate?
No.