Use DefaultServices for server_test #4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
reviewed
Jul 3, 2023
temporal/server_test.go
Outdated
| d.on.Store(false) | ||
| } | ||
|
|
||
| func (d *errorLogDetector) Warn(msg string, _ ...tag.Tag) { |
There was a problem hiding this comment.
should this (and Error) pass through the message to the underlying Logger? if not, maybe we shouldn't even have the Logger and just implement the rest of the methods as no-ops? if so, maybe we should make the Logger a stdout logger for help debugging?
There was a problem hiding this comment.
The underlying logger was a noopLogger, and I re-used it for the sake of brevity. However, I think that using a real logger and delegating to it for debugging is probably better. Updated.
MichaelSnowden
force-pushed
the
snowden/default-services
branch
3 times, most recently
from
d4e0ce9
to
3dcc0e1
Compare
dnr
approved these changes
Jul 3, 2023
MichaelSnowden
force-pushed
the
snowden/default-services
branch
from
2107508
to
d3a7b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
ForServices(DefaultServices)in the server test.Why?
How did you test it?
I ran it locally 10 times, and twice on the CI.
Potential risks
Could easily become a flaky test.
Is hotfix candidate?
No