Set ParentClosePolicy default value #481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
ParentClosePolicy
on request is set toTerminate
if case if not specified.WorkflowIdReusePolicy
is also set to default value inhandleDecisionStartChildWorkflow
.Why?
taskProcessor
returns error ifParentClosePolicy
orWorkflowIdReusePolicy
is not specified on request and there is no validation logic for it.How did you test it?
Run all tests (including Go SDK integration tests).
Potential risks
No risks.