Add FaultInjectionDataStoreFactory.NewQueueV2 implementation #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Sep 19, 2023
MichaelSnowden
force-pushed
the
snowden/dlq-telemetry
branch
from
8d0cfa0
to
3912b0b
Compare
MichaelSnowden
force-pushed
the
snowden/dlq-fault-injection
branch
from
fda7b03
to
313919b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I implemented
FaultInjectionDataStoreFactory.NewQueueV2.Why?
We implement this for all data stores. We don't have an actual use-case yet, but it may be helpful later if we want integration tests that test that our system can work even if the new queue experiences some errors.
How did you test it?
I added 100% test coverage.
Potential risks
Is hotfix candidate?