Add QueueV2.CreateQueue and implement it for Cassandra #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
snowden/dlq-feature
branch
from
d5c97d6
to
ea5d1b5
Compare
MichaelSnowden
force-pushed
the
snowden/create-queue
branch
2 times, most recently
from
517054a
to
501338b
Compare
MichaelSnowden
force-pushed
the
snowden/create-queue
branch
4 times, most recently
from
082e881
to
22c4822
Compare
yycptt
reviewed
Oct 1, 2023
MichaelSnowden
force-pushed
the
snowden/create-queue
branch
from
22c4822
to
ff884aa
Compare
yycptt
approved these changes
Oct 6, 2023
MichaelSnowden
force-pushed
the
snowden/create-queue
branch
from
ff884aa
to
bae1a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added the
CreateQueuemethod to theQueueV2interface. I also implemented it for Cassandra. Finally, I added some validation for the read and write methods of queue messages to check that their corresponding queue exists.Why?
We need to create queues to track the minimum message ID in order to prevent us from scanning over deleted tombstone messages in Cassandra when reading from the front of the queue.
How did you test it?
There is 100% test coverage for everything.
Potential risks
Is hotfix candidate?