Emit action metrics for batch of markers #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Sep 27, 2023
| // One workflow task response may contain multiple marker commands. Each marker will emit one | ||
| // command_RecordMarker_Xxx action metric. Depending on pricing model, you may want to ignore all individual | ||
| // command_RecordMarker_Xxx and use command_BatchMarkers instead. | ||
| metricsHandler.Counter(metrics.ActionCounter.GetMetricName()).Record(1, metrics.ActionType("command_BatchMarkers")) |
There was a problem hiding this comment.
so action metric will double count? and people need to change the query to exclude either all of command_RecordMarker_Xxx or command_BatchMarkers to get the right count?
There was a problem hiding this comment.
Yes. Current OSS action metrics include all commands, but not all commands are billable actions.
There was a problem hiding this comment.
cc @feihuang after ^ is deployed, the sum of action metric across action_type will double count.
yycptt
approved these changes
Sep 30, 2023
rodrigozhou
pushed a commit
that referenced
this pull request
Oct 30, 2023
<!-- Describe what has changed in this PR --> **What changed?** Add action metric for batch of markers <!-- Tell your future self why have you made these changes --> **Why?** Markers in one workflow task maybe counted as one action. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?**
rodrigozhou
pushed a commit
that referenced
this pull request
Oct 30, 2023
<!-- Describe what has changed in this PR --> **What changed?** Add action metric for batch of markers <!-- Tell your future self why have you made these changes --> **Why?** Markers in one workflow task maybe counted as one action. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?**
rodrigozhou
pushed a commit
that referenced
this pull request
Oct 31, 2023
<!-- Describe what has changed in this PR --> **What changed?** Add action metric for batch of markers <!-- Tell your future self why have you made these changes --> **Why?** Markers in one workflow task maybe counted as one action. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add action metric for batch of markers
Why?
Markers in one workflow task maybe counted as one action.
How did you test it?
Potential risks
Is hotfix candidate?