Add tdbg dlq purge for v2 #5023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
snowden/dlq-purge
branch
from
265942d
to
4d9e4b1
Compare
yycptt
approved these changes
Oct 25, 2023
tools/tdbg/dlq_service.go
Outdated
Comment on lines
87
to
94
| if len(sourceCluster) == 0 { | ||
| sourceCluster = targetCluster | ||
| } |
There was a problem hiding this comment.
nit: required for the replication queue?
There was a problem hiding this comment.
Good idea, added validation and a test for it.
MichaelSnowden
force-pushed
the
snowden/no-wrapper
branch
from
f276a6b
to
e0ca667
Compare
MichaelSnowden
force-pushed
the
snowden/dlq-purge
branch
from
4d9e4b1
to
930c529
Compare
MichaelSnowden
force-pushed
the
snowden/dlq-purge
branch
from
930c529
to
2da103b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added the ability to purge DLQ tasks from
tdbg.Why?
How did you test it?
I added an end-to-end test which starts a workflow that produces terminally failing tasks, verifies that it's added to the DLQ, and then uses the new tdbg purge command to delete the DLQ tasks.
Potential risks
Is hotfix candidate?