Validate search attributes values in queries to ES #5036
Merged
+211
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Oct 25, 2023
Comment on lines
206
to
207
| case int64: | ||
| value = time.Unix(0, v).UTC().Format(time.RFC3339Nano) |
There was a problem hiding this comment.
is this (treat int as nanoseconds) current behavior?
There was a problem hiding this comment.
Yes, this is the default behavior
common/persistence/visibility/store/elasticsearch/query_interceptors.go
Outdated
Show resolved
Hide resolved
rodrigozhou
force-pushed
the
es-validate-query-value-types
branch
from
62b4f41
to
e20fbbb
Compare
yiminc
approved these changes
Oct 26, 2023
rodrigozhou
added a commit
that referenced
this pull request
Oct 30, 2023
<!-- Describe what has changed in this PR --> **What changed?** Validate search attribute values in the SQL query to ES visibility store <!-- Tell your future self why have you made these changes --> **Why?** Better error handling for UX <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Updated unit tests. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
rodrigozhou
added a commit
that referenced
this pull request
Oct 30, 2023
<!-- Describe what has changed in this PR --> **What changed?** Validate search attribute values in the SQL query to ES visibility store <!-- Tell your future self why have you made these changes --> **Why?** Better error handling for UX <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Updated unit tests. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
rodrigozhou
added a commit
that referenced
this pull request
Oct 31, 2023
<!-- Describe what has changed in this PR --> **What changed?** Validate search attribute values in the SQL query to ES visibility store <!-- Tell your future self why have you made these changes --> **Why?** Better error handling for UX <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Updated unit tests. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Validate search attribute values in the SQL query to ES visibility store
Why?
Better error handling for UX
How did you test it?
Updated unit tests.
Potential risks
No.
Is hotfix candidate?
No.