Add parent workflow info to visibility schema #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
vis-parent-wf-schema
branch
from
63741a4
to
dc0ccff
Compare
stephanos
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Naive question: why wouldn't we create a new version v1.5? If v1.4 is rolled out already, wouldn't people not get this update?
There was a problem hiding this comment.
We only release schema changes with minor release. v1.4 was added after v1.22 was released.
nichtverstehen
pushed a commit
to nscloud-demo/temporal
that referenced
this pull request
Nov 23, 2023
<!-- Describe what has changed in this PR --> **What changed?** Add parent execution search attributes to ES mappings <!-- Tell your future self why have you made these changes --> **Why?** PR temporalio#5054 modified the SQL schemas to add parent execution to visibility. This one does for ES. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Unit Tests. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add parent workflow info to visibibility schema
Why?
How did you test it?
Unit tests
Potential risks
No.
Is hotfix candidate?
No.