-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-reapply 4: Functional tests of scenarios involving updates and history replication #5595
Merged
dandavison
merged 11 commits into
main
from
ndc-conflict-functional-tests-update-reapply
Apr 23, 2024
Merged
update-reapply 4: Functional tests of scenarios involving updates and history replication #5595
dandavison
merged 11 commits into
main
from
ndc-conflict-functional-tests-update-reapply
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
ndc-conflict-functional-tests
branch
2 times, most recently
from
March 26, 2024 14:14
5e58033
to
e785d10
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
2 times, most recently
from
March 26, 2024 14:22
3e2e7c0
to
35556c9
Compare
dandavison
commented
Mar 26, 2024
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
March 28, 2024 17:51
d7b3b85
to
0ec0b9e
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests
branch
from
March 28, 2024 17:52
e785d10
to
0ad39ad
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests
branch
from
April 8, 2024 10:29
0ad39ad
to
1d87277
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
4 times, most recently
from
April 8, 2024 16:14
5c433e8
to
d0bcf40
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests
branch
from
April 8, 2024 19:23
1d87277
to
8a7751e
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
April 8, 2024 19:24
d0bcf40
to
782e9fb
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests
branch
from
April 9, 2024 12:20
8a7751e
to
0dc8396
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
April 9, 2024 12:22
782e9fb
to
d77900b
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests
branch
from
April 9, 2024 12:37
0dc8396
to
58937d1
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
April 9, 2024 12:37
d77900b
to
9db463d
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests
branch
from
April 9, 2024 13:03
58937d1
to
608743c
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
April 9, 2024 13:03
9db463d
to
ccb993d
Compare
dandavison
commented
Apr 9, 2024
dandavison
force-pushed
the
ndc-conflict-functional-tests
branch
from
April 9, 2024 21:01
608743c
to
74be8f7
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
3 times, most recently
from
April 13, 2024 14:27
ec91aa5
to
b1c5fe5
Compare
dandavison
commented
Apr 18, 2024
dandavison
commented
Apr 18, 2024
dandavison
commented
Apr 18, 2024
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
April 18, 2024 15:21
59bb98f
to
2446a34
Compare
I'm looking into the test failures, but feel free to review. |
yycptt
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look awesome!
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
April 22, 2024 20:24
396eb8f
to
d21786d
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
April 22, 2024 21:04
d21786d
to
b89117b
Compare
alexshtin
approved these changes
Apr 23, 2024
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
3 times, most recently
from
April 23, 2024 19:10
3bceb9a
to
b4ea111
Compare
dandavison
force-pushed
the
ndc-conflict-functional-tests-update-reapply
branch
from
April 23, 2024 19:44
b4ea111
to
80bb7b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functional test coverage for various scenarios involving updates and history event replication:
TestConflictResolutionReappliesUpdates
: this test passes without requiring further changes (the necessary work was done in the previous PRs addressing WorkflowReset and reapplying updates).TestAcceptedUpdateCanBeCompletedAfterFailoverAndFailback
,TestUpdateCompletedAfterFailoverCannotBeCompletedAgainAfterFailback
: to make these tests pass, this PR modifies update registry mechanics: we now update the registry from mutable state every time we obtain the registry from the workflow context. This is needed because, when we failback to cluster 1 after a failover, cluster 1 already has a populated registry, which must be brought up to date with events in history received from cluster2 (and hence in mutable state).@alexshtin and I are discussing an alternative solution based on dropping the registry instead of updating it, so a future PR may change the way that the tests introduced here are satisfied.
TestConflictResolutionReappliesUpdatesSameIds
: this test fails and is skipped; it will be addressed in the next PR.Potential risks
If the update registry changes here are incorrect then update could be broken in various ways.
Is hotfix candidate?
No