-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for forwarding Nexus HTTP requests #5793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Apr 25, 2024
bergundy
reviewed
May 7, 2024
bergundy
reviewed
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly LGTM, I left a few more comments.
bergundy
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I had left was nits, merge at will.
ychebotarev
pushed a commit
that referenced
this pull request
May 28, 2024
## What changed? <!-- Describe what has changed in this PR --> * Added a new component `cluster.HttpClientCache` which serves a similar purpose to our gRPC `ClientBean` but provides HTTP clients for remote clusters. * Added logic to forward Nexus requests from standby clusters to active. * Exposed frontend `namespace.Registry` from our test `temporalImpl` so that tests can use `Eventually` functions to wait for namespace data to be updated in-memory without having to use `time.Sleep` ## Why? <!-- Tell your future self why have you made these changes --> So that Nexus requests can be forwarded across clusters. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> New unit and functional tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
cluster.HttpClientCache
which serves a similar purpose to our gRPCClientBean
but provides HTTP clients for remote clusters.namespace.Registry
from our testtemporalImpl
so that tests can useEventually
functions to wait for namespace data to be updated in-memory without having to usetime.Sleep
Why?
So that Nexus requests can be forwarded across clusters.
How did you test it?
New unit and functional tests.