Revert "Enable FE proxying history reads to history service as default (#5736)" #5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Apr 25, 2024
norberthu
added a commit
that referenced
this pull request
Apr 26, 2024
## What changed? This enables frontend+matching reading history through history service ## Why? This is the prereq for #5797
yycptt
pushed a commit
that referenced
this pull request
Apr 26, 2024
## What changed? This enables frontend+matching reading history through history service ## Why? This is the prereq for #5797
norberthu
added a commit
that referenced
this pull request
May 30, 2024
This is a re-revert of #5797 now that all changes moving forward will be part of 1.25 release. ## Why? The new logic to proxy all FE history read operations to the history service has been part of release 1.23 and it is now safe (w.r.t. FE and history services deployment ordering) as part of release 1.25 to start deprecating the legacy code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This reverts commit 3f1bdfb.
Why?
This cleanup of deprecated code must wait until after the minor release
with #5798