Handle NextRetryDelay option in workflow failures #5946
Merged
+42
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
May 20, 2024
yycptt
reviewed
May 20, 2024
No. It's meant to handle failure with NextRetryDelay in any attempt of the workflow task. What gave you the impression that it's applied only to the first attempt? |
gow
changed the title
Synced offline. The confusion was me calling it "workflow task" which is a different construct than the workflow code (or simply workflow). This change works as intended for the workflows where it can return an application error to customize its next retry delay. |
stephanos
pushed a commit
that referenced
this pull request
Jun 13, 2024
Workflows can now return an application error with NextRetryDelay option
to customize when the workflow will be retried again.
```
return temporal.NewApplicationError(
"some retryable error",
"SomeType",
temporal.ApplicationErrorOptions{NextRetryDelay: 2 * time.Minute},
)
```
Currently Activity tasks can customize the next retry time. This is
bringing the same feature to workflow tasks as well.
Added unit tests.
Also added a test to assert next retry delay customization in
activities.
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No
dandavison
added a commit
to dandavison/temporalio-sdk-typescript
that referenced
this pull request
Jul 10, 2024
dandavison
added a commit
to dandavison/temporalio-sdk-python
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Workflows can now return an application error with NextRetryDelay option to customize when the workflow will be retried again.
Why?
Currently Activity tasks can customize the next retry time. This is bringing the same feature to workflow tasks as well.
How did you test it?
Added unit tests.
Also added a test to assert next retry delay customization in activities.
Potential risks
Documentation
Is hotfix candidate?
No