Properly check report pollers and report reachability flags #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
May 23, 2024
yiminc
reviewed
May 23, 2024
ShahabT
added a commit
that referenced
this pull request
May 24, 2024
## What changed? <!-- Describe what has changed in this PR --> Properly check report pollers and report reachability flags in enhanced DescribeTaskQueue. ## Why? <!-- Tell your future self why have you made these changes --> This is a bug. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Existing tests. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> none. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> none. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> yes. (cherry picked from commit c5cb979)
pdoerner
pushed a commit
that referenced
this pull request
May 31, 2024
## What changed? <!-- Describe what has changed in this PR --> Properly check report pollers and report reachability flags in enhanced DescribeTaskQueue. ## Why? <!-- Tell your future self why have you made these changes --> This is a bug. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Existing tests. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> none. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> none. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Properly check report pollers and report reachability flags in enhanced DescribeTaskQueue.
Why?
This is a bug.
How did you test it?
Existing tests.
Potential risks
none.
Documentation
none.
Is hotfix candidate?
yes.