Next retry delay should not be bounded by retry policy MaximumInterval #6063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeebswihart
approved these changes
Jun 5, 2024
stephanos
pushed a commit
that referenced
this pull request
Jun 13, 2024
#6063) When an activity specifies `next_retry_delay` in the application failure, we should be ignoring the max interval set in the retry policy. This PR allows it. The intention of the application here is to override the retry policy and customize the next attempt time. https://github.com/temporalio/api/blob/5b356b506e0b86ba26dc6f795bfb011eeb4dfa6e/temporal/api/failure/v1/message.proto#L49 Added unit test. N/A N/A No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When an activity specifies
next_retry_delayin the application failure, we should be ignoring the max interval set in the retry policy. This PR allows it.Why?
The intention of the application here is to override the retry policy and customize the next attempt time.
https://github.com/temporalio/api/blob/5b356b506e0b86ba26dc6f795bfb011eeb4dfa6e/temporal/api/failure/v1/message.proto#L49
How did you test it?
Added unit test.
Potential risks
N/A
Documentation
N/A
Is hotfix candidate?
No