Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit Web to execute write requests by default #656

Merged
merged 2 commits into from Aug 5, 2020

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Aug 4, 2020

What changed?
Sets Web UI to allow Terminating workflows by default (As well as any other Write API)
Related PR - temporalio/web#97

Why?
Makes Terminating workflows functionality to be easily discoverable as it is enabled by default

How did you test it?
docker-compose up

Potential risks
no risks

Copy link
Contributor

@rylandg rylandg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feedmeapples feedmeapples merged commit a3d0334 into master Aug 5, 2020
@alexshtin alexshtin deleted the permit-write-from-web branch October 20, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants