Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Membership.Name config; Hardcode ringpop app name #688

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Remove Membership.Name config; Hardcode ringpop app name #688

merged 1 commit into from
Aug 25, 2020

Conversation

shawnhathaway
Copy link
Contributor

Unused configuration value, removing for clearness to consumers. Also formatting.

alexshtin
alexshtin approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@alexshtin alexshtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so sad to see mario go.

@shawnhathaway shawnhathaway changed the title Remove unused Membership.Name config Remove Membership.Name config; Hardcode ringpop app name Aug 25, 2020
@shawnhathaway
Copy link
Contributor Author

shawnhathaway commented Aug 25, 2020 •
edited
Loading

After re-reviewing here, I am following up in a separate change by using CurrentClusterName instead of hardcoding temporal.

@shawnhathaway shawnhathaway merged commit e9bb772 into temporalio:master Aug 25, 2020
@shawnhathaway shawnhathaway deleted the mem_name branch August 25, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawnhathaway @alexshtin