Add ability to specify client certificate and associated private key via base64 values in config #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add_support_for_astra
underrun
suggested changes
Sep 30, 2020
mastermanu
changed the title
mastermanu
changed the title
samarabbas
approved these changes
Oct 1, 2020
underrun
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for passing in client certificate / password data via the configuration through the use of "CertData" and "KeyData" fields respectively.
One can simply do:
and then paste the output as a value for each of the fields.
For now, both the client certificate and the key must be passed in via the same style (e.g. passing the certificate via a filepath and its associated key via base64 is not supported). This is not difficult to add, but will only add this if requested.
Verification: