Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds additional TLS configuration parameters #874

Merged
merged 6 commits into from
Oct 19, 2020
Merged

Adds additional TLS configuration parameters #874

merged 6 commits into from
Oct 19, 2020

Conversation

mastermanu
Copy link
Member

@mastermanu mastermanu commented Oct 17, 2020 •
edited

  • Adds ability to enable host validation to Internode/Frontend TLS configuration.
  • Updates config-template.yaml to surface environment variables for both serverName and enabling of host validation.
  • TCTL commands that leveraged the Go Client SDK were not setting the TLS configuration correctly on the Client, so those commands would fail against a Temporal Cluster with TLS enabled.

Tested against a private deployment

@mastermanu mastermanu requested review from feedmeapples and removed request for alexshtin October 17, 2020 22:57
sergeybykov
sergeybykov approved these changes Oct 17, 2020
View reviewed changes
tools/cli/factory.go Outdated Show resolved Hide resolved
@mastermanu mastermanu merged commit f3e0b03 into temporalio:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeybykov sergeybykov sergeybykov approved these changes

@wxing1292 wxing1292 wxing1292 approved these changes

@underrun underrun Awaiting requested review from underrun

@feedmeapples feedmeapples Awaiting requested review from feedmeapples

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mastermanu @sergeybykov @wxing1292