Add an option to tctl to override server name for TLS host verification #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added an option for
tctlto override server name for TLS host verification.Why?
When
tctlconnects to frontend over mTLS, the target server address or host name may differ from the CN in the server certificate, and that fails server host verification. This option allowstctlto specify the expected CN of the server it is connecting to.How did you test it?
Manually verified that
tctlis able to successfully connect to server by specifying--tls_server_nameoption where before it was failing to connect.Potential risks
No risk. This is an optional flag.