Fixes Dynamic Configuration bug where TaskType Constraint match always failed #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Oct 26, 2020
alexshtin
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Dynamic Configuration File-based logic was comparing a value that is typically supplied as an integer / string to an enum value, which would never match. As a result, any constraint that specified TaskQueueType would never match, which means that this constraint setting never worked.
This PR fixes this issue by converting the TaskType enum filter into its String equivalent, so the user can specify "Activity" or "Workflow" (case-sensitive)
Not in scope for this PR:
Verified this test on a local development environment and via unit-tests.
The breaking change risk here is minimal. The taskType constraint never worked properly in the first place. But, if someone has tested their system with the taskType constraint set (incorrectly assuming the override was applied), when they roll out this fix, they could see a change in the number of task queue partitions for this scenario, which, while not having a functional impact, could lead to a observed difference in performance.