v1.24.0-m1.3
xwduan
tagged this
18 Mar 23:54
## What changed? <!-- Describe what has changed in this PR --> 1. Fix stream_sender to return Stream error when there is error on stream 2. Avoid infinite retry on stream event loop wrapper ## Why? <!-- Tell your future self why have you made these changes --> 1. stream_sender's send/recv error is not properly wrapped, so the eventloop wrapper is retrying infinitely on the "rpc error" 2. Avoid the infinitely retry ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Unit test ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> No risk. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> n/a ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> Should only affecting 1.24.
Assets 2
-
2024-03-18T23:54:49Z -
2024-03-18T23:54:49Z -