Expose frontend host:port #11
Conversation
server.go
Outdated
| // FrontendHostPort returns the host:port for this server. | ||
| func (s *Server) FrontendHostPort() string { | ||
| return s.frontendHostPort | ||
| } | ||
|
|
There was a problem hiding this comment.
For your use case, would a method to return client.Options work as well?
Right now Temporalite really only needs a hostport to be set on the client, but in the future more client options may need to have modified default values and I would like to avoid confusion for end users about how to instantiate clients. I think this would make it possible to introspect things like hostport, but also decrease the chances that dependent code would break if/when Temporalite needs to further customize default client options.
There was a problem hiding this comment.
client.Options would work, though I might just be extracting the host:port out of it for some uses.
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 46.72% 46.57% -0.15%
==========================================
Files 11 11
Lines 625 627 +2
==========================================
Hits 292 292
- Misses 315 317 +2
Partials 18 18
Continue to review full report at Codecov.
|
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
What changed?
Exposed
FrontendHostPortWhy?
Some uses of temporalite may want to use this value for their own client creation, or in my case, pass it somewhere else for their use.
Ideally this would be
FrontendAddr() net.Addrand the system would support things like local unix paths and such, but I understand this is a Temporal server limitation too. I also considered just exposingFrontendPortsince127.0.0.1is hardcoded, but I assumed it may not be hardcoded always andhost:portcan be directly passed to different forms ofDial.How did you test it?
Untested getter.
Potential risks
None
Is hotfix candidate?
No