Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Add Dockerfile to support running in a container #16

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Add Dockerfile to support running in a container #16

merged 1 commit into from
Dec 20, 2021

Conversation

jbreiding
Copy link
Contributor

@jbreiding jbreiding commented Nov 29, 2021

Adding Dockerfile for demo purposes with temporal ui

What changed?
Adding a Dockerfile for local development

Why?
Setting up a local development environment using
https://github.com/jbreiding/potential-goggles

To work on and demo both code bases.

How did you test it?
docker and docker-compose
vscode devcontainers
GH codespaces

$ docker build -t temporalite:testv2 . --no-cache
$ docker run temporalite:testv2

Potential risks
None

Is hotfix candidate?
No.

cmd/temporalite/main.go Outdated Show resolved Hide resolved
internal/liteconfig/config.go Outdated Show resolved Hide resolved
internal/liteconfig/config.go Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #16 (1daacce) into main (e046f4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   45.39%   45.39%           
=======================================
  Files          11       11           
  Lines         652      652           
=======================================
  Hits          296      296           
  Misses        337      337           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e046f4e...1daacce. Read the comment docs.

@jbreiding jbreiding changed the title Add flag to expose frontend service on an address other than 127.0.0.1 Add Dockerfile to support running in a container Nov 30, 2021
@jbreiding jbreiding marked this pull request as ready for review November 30, 2021 03:22
Copy link
Collaborator

@jlegrone jlegrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbreiding I could also take a stab at this later, but would you be up for adding an e2e test to the Github CI workflow to ensure that the docker image can be successfully built and when executed exposes a healthy Temporal service endpoint?

Dockerfile Outdated Show resolved Hide resolved
@jbreiding
Copy link
Contributor Author

jbreiding commented Dec 18, 2021

@jbreiding I could also take a stab at this later, but would you be up for adding an e2e test to the Github CI workflow to ensure that the docker image can be successfully built and when executed exposes a healthy Temporal service endpoint?

Perhaps in another PR.
This would likely entail dockerizing the test worker from this repo or using tctl and maybe combining with a docker-compose example.

@jlegrone jlegrone merged commit 02655c7 into temporalio:main Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants