Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

changes tally to use v4.1.0 #20

Merged
merged 2 commits into from
Dec 13, 2021
Merged

changes tally to use v4.1.0 #20

merged 2 commits into from
Dec 13, 2021

Conversation

paganotoni
Copy link
Contributor

@paganotoni paganotoni commented Dec 4, 2021

This PR changes the dependency on Tally to use v4.1.0, this is to solve issue #18. I did run the tests as the workflow explains to ensure it still compiles and passes the tests.

Potential risks
I do not see any potential risks on this PR besides being able to import the temporalite go library (which is where we are now according to the issue).

Is hotfix candidate?
I would say it is a candidate for hotfix, not sure that this impacts other communities.

@paganotoni paganotoni changed the title changes tally to use v4.1.1 changes tally to use v4.1.0 Dec 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #20 (1cf2ecd) into main (6070027) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   45.06%   45.06%           
=======================================
  Files          11       11           
  Lines         648      648           
=======================================
  Hits          292      292           
  Misses        337      337           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6070027...1cf2ecd. Read the comment docs.

Copy link
Collaborator

@jlegrone jlegrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlegrone jlegrone merged commit ac001ab into temporalio:main Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants