This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
add sqlite pragma support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 45.39% 42.73% -2.67%
==========================================
Files 11 11
Lines 652 695 +43
==========================================
+ Hits 296 297 +1
- Misses 337 377 +40
- Partials 19 21 +2
Continue to review full report at Codecov.
|
jlegrone
reviewed
Dec 30, 2021
Initial review changes, need a few manual updates as well. Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
jlegrone
approved these changes
Dec 30, 2021
cmd/temporalite/main.go
Outdated
| @@ -35,6 +36,7 @@ const ( | |||
| ipFlag = "ip" | |||
| logFormatFlag = "log-format" | |||
| namespaceFlag = "namespace" | |||
| pragmaFLag = "sqlite-pragma" | |||
There was a problem hiding this comment.
typo
Suggested change
| pragmaFLag = "sqlite-pragma" | |
| pragmaFlag = "sqlite-pragma" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adds ability to specify sqlite pragma statements from CLI.
Why?
Pragmas allow tweaking sqlite settings to particular use cases including improved performance. See #26
How did you test it?
Manually validated options caused desired sqlite changes.
Potential risks
User could supply pragma statements incompatible with temporalite functionality or resulting in corrupt databases.
Is hotfix candidate?
No.