Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Use dynamic ports from CLI #48

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Use dynamic ports from CLI #48

merged 1 commit into from
Feb 28, 2022

Conversation

jlegrone
Copy link
Collaborator

What changed?

Updates the temporalite CLI to always use dynamic ports.

Why?

Previously ports for internal APIs were assigned by adding a hardcoded offset to the frontend grpc port. About 10 ports are computed in this way, leading to a high chance of conflicts.

Closes #34.

How did you test it?

Potential risks

Some users may have been depending on the previous behavior, since pprof and metrics ports were predictable (though this was never documented). Explicit flags for setting those ports can be added later.

Is hotfix candidate?

No

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #48 (3a89a41) into main (4c73c85) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   41.93%   41.87%   -0.06%     
==========================================
  Files          11       11              
  Lines         725      726       +1     
==========================================
  Hits          304      304              
- Misses        399      400       +1     
  Partials       22       22              
Impacted Files Coverage Δ
cmd/temporalite/main.go 1.36% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c73c85...3a89a41. Read the comment docs.

@jlegrone jlegrone force-pushed the jlegrone/always-dynamic-ports branch from 61636e6 to 3a89a41 Compare February 26, 2022 04:38
@jlegrone jlegrone merged commit 5a5ad37 into main Feb 28, 2022
@jlegrone jlegrone deleted the jlegrone/always-dynamic-ports branch February 28, 2022 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port 7335 (ringpop) is already commonly used by Figma
3 participants