Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Support parallel temporaltest executions and non-cgo builds #6

Merged
merged 7 commits into from
Sep 20, 2021

Conversation

jlegrone
Copy link
Collaborator

What changed?

  • Added support for building with CGO_ENABLED=0 via modernc.org/sqlite
  • Updated storage driver registration to support concurrent temporaltest executions

@codecov-commenter
Copy link

Codecov Report

Merging #6 (2f33df8) into main (7986b5b) will decrease coverage by 4.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   46.47%   42.41%   -4.07%     
==========================================
  Files          23       24       +1     
  Lines        2201     2143      -58     
==========================================
- Hits         1023      909     -114     
- Misses       1109     1172      +63     
+ Partials       69       62       -7     
Impacted Files Coverage Δ
cmd/temporalite/main.go 2.19% <ø> (ø)
...rnal/common/persistence/sql/sqlplugin/sqlite/db.go 69.04% <ø> (+4.60%) ⬆️
...mon/persistence/sql/sqlplugin/sqlite/driver_cgo.go 0.00% <0.00%> (ø)
...mmon/persistence/sql/sqlplugin/sqlite/namespace.go 56.63% <ø> (ø)
internal/licensecheck/main.go 0.00% <0.00%> (ø)
server.go 74.46% <0.00%> (+1.39%) ⬆️
.../common/persistence/sql/sqlplugin/sqlite/plugin.go 63.24% <52.94%> (-1.67%) ⬇️
internal/liteconfig/config.go 90.14% <100.00%> (+0.35%) ⬆️
...ommon/persistence/sql/sqlplugin/sqlite/typeconv.go 50.00% <0.00%> (-50.00%) ⬇️
.../common/persistence/sql/sqlplugin/sqlite/events.go 43.83% <0.00%> (-32.88%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7986b5b...2f33df8. Read the comment docs.

Copy link

@jprobinson jprobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐚 🌯

@jlegrone jlegrone merged commit c9203bf into main Sep 20, 2021
@jlegrone jlegrone deleted the jlegrone/no-cgo branch September 20, 2021 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants