Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Route temporaltest logs to testing.T logger #7

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

jlegrone
Copy link
Collaborator

@jlegrone jlegrone commented Sep 20, 2021

What changed?

  • Added temporaltest option to configure custom logger that leverages testing.T logging methods
  • Silenced schema setup logs during tests (depends on Add custom logger option to schema tool temporal#1943)
  • Added a Worker method to temporaltest that reduces boilerplate related to starting/stopping workers and also routes worker logs to current test context

@jlegrone jlegrone marked this pull request as ready for review September 21, 2021 17:45
@codecov-commenter
Copy link

Codecov Report

Merging #7 (0a4151f) into main (c9203bf) will increase coverage by 0.79%.
The diff coverage is 76.47%.

❗ Current head 0a4151f differs from pull request most recent head 7af5b6e. Consider uploading reports for the commit 7af5b6e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   42.41%   43.21%   +0.79%     
==========================================
  Files          24       26       +2     
  Lines        2143     2203      +60     
==========================================
+ Hits          909      952      +43     
- Misses       1172     1188      +16     
- Partials       62       63       +1     
Impacted Files Coverage Δ
.../common/persistence/sql/sqlplugin/sqlite/plugin.go 61.98% <60.00%> (-1.27%) ⬇️
temporaltest/server.go 78.08% <72.97%> (-7.64%) ⬇️
temporaltest/logger.go 73.33% <73.33%> (ø)
internal/liteconfig/config.go 90.14% <100.00%> (ø)
temporaltest/options.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9203bf...7af5b6e. Read the comment docs.

@jlegrone jlegrone merged commit 3b71bff into main Sep 21, 2021
@jlegrone jlegrone deleted the jlegrone/test-logger branch September 21, 2021 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants