This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Allow overriding base Temporal server config and client options #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jun 8, 2022
cretz
reviewed
Jun 8, 2022
cretz
approved these changes
Jun 8, 2022
jlegrone
reviewed
Jun 15, 2022
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 39.55% 39.52% -0.03%
==========================================
Files 12 12
Lines 766 802 +36
==========================================
+ Hits 303 317 +14
- Misses 441 463 +22
Partials 22 22
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jlegrone
reviewed
Jun 21, 2022
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
jlegrone
reviewed
Jun 28, 2022
jlegrone
approved these changes
Jun 28, 2022
jlegrone
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added command line options to specify certificates to enable tls and mutual tls.
Why?
This change allows more thorough SDK testing without having to stand up a temporal server.
How did you test it?
Potential risks
The worst case scenario is that use cases without tls no longer work
Is hotfix candidate?
No