This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Update Go module name #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlegrone
commented
Jul 29, 2022
| @@ -1,4 +1,4 @@ | |||
| module github.com/DataDog/temporalite | |||
| module github.com/temporalio/temporalite | |||
There was a problem hiding this comment.
Do we actually want to use a vanity url here eg. go.temporal.io/temporalite?
There was a problem hiding this comment.
After off-PR discussion, while we'll confirm with a larger audience internally, this is good to start with instead of a vanity URL
There was a problem hiding this comment.
Discussed in slack -- we'll go ahead and merge as-is for now. We may still update the module name again in the future.
cretz
approved these changes
Jul 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updates the module name from
github.com/DataDog/temporalitetogithub.com/temporalio/temporalite.Why?
The source repository has changed ownership in GitHub.
How did you test it?
Potential risks
Is hotfix candidate?